Attach LastResponse after unmarshaling #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur-stripe
approved these changes
Jun 11, 2020
There was a problem hiding this comment.
LGTM. And yeah, I think that check on v is probably just a code artifact from before some previous refactoring.
It might not be too bad to write a test for this by just creating a specific type with UnmarshalJSON for the purposes of the test, but it probably doesn't matter too much. I'd say that this isn't too likely to regress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a resource has a custom
UnmarshalJSONfile likeChargedoes, we lose theLastResponseproperty of theAPIResourcedue to ordering.Additionally—there's a guard here which doesn't make much sense which I've removed. If
vis ever nil here, we'd panic before hitting the guard.I found it kind of awkward to write a test for this behavior—the existing test in
stripe_test.godoesn't expose it because it has no custom UnmarshalJSON defined; if you look at the definition forChargeyou can see it completely overwrites the object (as do several others).r? @brandur-stripe
cc @stripe/api-libraries